Ensures highlighting of all nodes that are spoken #1349
+136
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1349 +/- ##
==========================================
Coverage 86.72% 86.72%
==========================================
Files 337 337
Lines 84145 84145
Branches 3140 4769 +1629
==========================================
Hits 72971 72971
+ Misses 11174 11151 -23
- Partials 0 23 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you provide one of the examples that you have where the additional highlighting is necessary? I don't remember the format we looked at together last week. |
|
The problem came out of the MJ issue 3419. Examples are there too. E.g., \int _{C} {\mathbb{P}f}\mathcal{M} |
|
I'm getting errors from SRE. Do I need an updated copy? If so, can you say what branch I should use? |
dpvc
requested changes
Sep 11, 2025
|
I incorporated your comments. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR ensures that all formula elements that are spoken are highlighted. This is necessary when parts of the formula are not in the same DOM subtree that is rooted by the node that contains the speech.
The idea is to compute the set difference between the nodes in the subtree and the id numbers given in the semantic structure of the elements. For this we add a
subtreesmap that is initially populated with the information fromdata-semantic-structure.Currently nodes are highlighted separately. What is still missing is a combined highlighting as discussed last week. I tried a couple of ideas, but none looked good in particular if there are also linebreaks in the expression.